Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue Composition API v1.0.0-beta.14 breaks package #238

Closed
aaronhuisinga opened this issue Sep 15, 2020 · 2 comments · Fixed by #239
Closed

Vue Composition API v1.0.0-beta.14 breaks package #238

aaronhuisinga opened this issue Sep 15, 2020 · 2 comments · Fixed by #239
Assignees
@danielroe
Labels
bug Something isn't working

Comments

@aaronhuisinga
Copy link

🐛 The bug
The new release of Vue Composition API (v1.0.0-beta.14) breaks this package. The new release removes the markReactive export (vuejs/composition-api#512), which the Nuxt Composition API currently depends on.

When attempting to compile our Nuxt app after updating the Vue Composition API, we get the following error:

 ✖ Nuxt Fatal Error                                                                                                │
   │                                                                                                                     │
   │   SyntaxError: The requested module                                                                                 │
   │   'file:///Users/xxx/Documents/code/xxx/client/node_modules/@vue/composition-api/index.js' does not   │
   │   provide an export named 'markReactive'

🛠️ To reproduce
Steps to reproduce the behavior:

  1. Update Vue Composition package to v1.0.0-beta.14
  2. Run yarn dev
@aaronhuisinga aaronhuisinga added the bug Something isn't working label Sep 15, 2020
@JamieCurnow JamieCurnow mentioned this issue Sep 16, 2020
Merged
@JamieCurnow
Copy link
Contributor

If anyone is looking for a workaround until this is fixed, add a resolution to your package.json for @vue/composition-api:

"resolutions": {
    "@vue/composition-api": "1.0.0-beta.13"
  }

@liaojunhong
Copy link

This is because the 1.0.0-beta.14 version of vue-composition-api has been updated and markReactive has been removed

danielroe pushed a commit that referenced this issue Sep 16, 2020
@JamieCurnow
fix: remove markReactive export (#239)
d455d0f 
was removed from `@vue/composition-api`

closes #238
danielroe added a commit that referenced this issue Sep 16, 2020
@danielroe
chore: upgrade @vue/composition-api
fad53c1 
* adds `version` export
* removes `markReactive` export (#238)

BREAKING CHANGES: removes `markReactive` export
danielroe added a commit that referenced this issue Sep 17, 2020
@danielroe
fix: transpile @vue/composition-api
4c240f8 
* you can now remove `@vue/composition-api` from your dependencies
* this allows us to track a particular beta version more closely to prevent future breaking changes

closes #241, #238

BREAKING CHANGES: you should remove `@vue/composition-api` from your dependencies
danielroe added a commit that referenced this issue Sep 18, 2020
@danielroe
chore: upgrade vue composition api (#240)
ad72689 
* adds `version` export
* removes `markReactive` export (#238)
* we now depend on a particular beta version more closely to prevent future breaking changes

BREAKING CHANGES: removes `markReactive` export

closes #241, #238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove markReactive export JamieCurnow/composition-api
4 participants
@aaronhuisinga @danielroe @JamieCurnow @liaojunhong