-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: package changes #438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than comments, LGTM 👍
Co-authored-by: pooya parsa <pyapar@gmail.com>
unrelated: ensure all runtime deps are transpiled for legacy browser support
Some issues discovered with test deploy:
|
I think jest only expects export to existing since we are using
It is a little bit confusing since assumptions in that issue are based on before this PR for doing dedup by alias. Also as mentioned in commit comment, transpile is for transpile (not side-effect of inlining). I guarantee you it is right thing to do :) |
@pi0 I mean we need to produce it for end-users who want to use jest testing:
|
Is mentioned instruction for testing a vue component that uses |
No description provided.