refactor: extract vca registration into an external/shared js file #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added a commit
that referenced
this pull request
May 17, 2021
* addresses issue with .mjs format (nuxt + jest) * uses `require.resolve` to locate templates * compile composables into single file * reverts 16e21eb (#470) * retains auto-registration for testing (in cjs export - if `process.env.NODE_ENV === 'test'`) closes #476, closes #479 (by implementing), closes nuxt/vite#134, closes nuxt/vite#123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're no longer quite so tied to Nuxt implementation details. And as a side effect,
jestusers don't have to register VCA manually (unintentional regression from #438).closes #468
HT: @pi0