Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

fix: overwrite titleTemplate with undefined #218

Closed
wants to merge 3 commits into from
Closed

fix: overwrite titleTemplate with undefined #218

wants to merge 3 commits into from

Conversation

mathe42
Copy link
Collaborator

@mathe42 mathe42 commented Aug 24, 2020

fixes #169

@vercel
Copy link

vercel bot commented Aug 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-community/composition-api/db9if5chr
✅ Preview: https://composition-api-git-fork-mathe42-patch-4.nuxt-community.vercel.app

@mathe42 mathe42 marked this pull request as ready for review August 24, 2020 21:31
@mathe42
Copy link
Collaborator Author

mathe42 commented Aug 24, 2020

@danielroe you can review this.

@mathe42
Copy link
Collaborator Author

mathe42 commented Aug 24, 2020

Checked other fields in vue-meta there are no other problems like this.

danielroe
danielroe previously approved these changes Aug 25, 2020
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great - thanks!

suggestion (non-blocking): What do you think about adding an e2e test that would have failed without this addition?

src/meta.ts Show resolved Hide resolved
@mathe42
Copy link
Collaborator Author

mathe42 commented Aug 25, 2020

We could add an e2e test would be nice but I dont have the time to work on that... (in the next 1-2 Weeks...)

src/meta.ts Outdated Show resolved Hide resolved
Co-authored-by: Daniel Roe <daniel@roe.dev>
@danielroe
Copy link
Member

danielroe commented Aug 26, 2020

Switching to #220 (local branch) to push e2e test etc.

@danielroe danielroe closed this Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: useMeta effect titleTemplate setting in nuxt.config.js doesn't work
2 participants