-
Notifications
You must be signed in to change notification settings - Fork 100
fix: overwrite titleTemplate with undefined #218
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nuxt-community/composition-api/db9if5chr |
@danielroe you can review this. |
Checked other fields in vue-meta there are no other problems like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - thanks!
suggestion (non-blocking): What do you think about adding an e2e test that would have failed without this addition?
We could add an e2e test would be nice but I dont have the time to work on that... (in the next 1-2 Weeks...) |
Co-authored-by: Daniel Roe <daniel@roe.dev>
Switching to #220 (local branch) to push e2e test etc. |
fixes #169