Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compositionAPI flag in jsx babel configuration #304

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

mathieutu
Copy link
Contributor

fix #303.

It could be good to add some tests to validate the behaviour, but I actually have no idea how to test that.

👋

@vercel
Copy link

vercel bot commented Nov 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-community/composition-api/jwr7rv8kd
✅ Preview: https://composition-api-git-feat-babel-jsx.nuxt-community.vercel.app

Copy link
Member

Can you think of a good way to ensure we don't apply this configuration to all users but only those using JSX? (Alternatively, are there any downsides to applying this to all users?)

@mathieutu
Copy link
Contributor Author

mathieutu commented Dec 24, 2020

I don't know or see any downside actually. Maybe the fact that this will be converted to getCurrentInstance automatically ?

And I don't see how we can detect some jsx. Nuxt handles jsx by default, so I think we should handle that by default too.

@danielroe danielroe merged commit fec4218 into nuxt-community:main Jan 25, 2021
@danielroe
Copy link
Member

Thanks again for this @mathieutu ❤️

@mathieutu
Copy link
Contributor Author

@danielroe My pleasure, thanks to you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Enable jsx support
2 participants