Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

fix: set useFetch delay to 0 by default #362

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Conversation

manniL
Copy link
Member

@manniL manniL commented Feb 4, 2021

Fixes: #359

Sets the default useFetch delay to 0 😋

@vercel
Copy link

vercel bot commented Feb 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-community/composition-api/jaj96svz5
✅ Preview: https://composition-api-git-fix-use-fetch-ttfb.nuxt-community.vercel.app

@manniL manniL changed the title test: add failing ttfb test fix: set useFetch delay to 0 by default Feb 4, 2021
@manniL manniL requested a review from danielroe February 4, 2021 14:43
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work catching this.

src/fetch.ts Outdated Show resolved Hide resolved
@danielroe danielroe merged commit 33b9790 into main Feb 4, 2021
@danielroe danielroe deleted the fix/use-fetch-ttfb branch February 4, 2021 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: useFetch perf is significantly worse than useAsync
2 participants