Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow custom globalContext and globalNuxt #80

Merged
merged 1 commit into from
May 27, 2020
Merged

Conversation

danielroe
Copy link
Member

closes #37

@danielroe danielroe self-assigned this May 27, 2020
@vercel
Copy link

vercel bot commented May 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-community/composition-api/riqbkxgpa
✅ Preview: https://composition-api-git-globals-context.nuxt-community.now.sh

@danielroe danielroe merged commit 8b8d7eb into master May 27, 2020
@danielroe danielroe deleted the globals-context branch May 27, 2020 22:55
@KNTH01
Copy link

KNTH01 commented May 28, 2020

Hey @danielroe :)

I might have a regression since I've upgrade to 0.7.3 regarding the useContext during pre-rendering with nuxt generate.

image

@danielroe
Copy link
Member Author

@KevinNTH Odd 🤔 Would you confirm that you have added nuxt-composition-api to your buildModules?

@KNTH01
Copy link

KNTH01 commented May 28, 2020

Yes!

   /*
   ** Nuxt.js dev-modules
   */
  buildModules: [
    // https://composition-api.now.sh
    'nuxt-composition-api',
    // Doc: https://github.com/nuxt-community/eslint-module
    '@nuxtjs/eslint-module',
    // Doc: https://github.com/nuxt-community/nuxt-tailwindcss
    '@nuxtjs/tailwindcss',
   ],

danielroe added a commit that referenced this pull request May 28, 2020
fixes regression introduced in #80
@danielroe
Copy link
Member Author

@KevinNTH Better luck now with 0.7.4?

@KNTH01
Copy link

KNTH01 commented Jun 1, 2020

Yes, it works fine! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: respect globals.context
2 participants