-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: programmatic netlify.toml support & copying #11
Merged
TheAlexLichter
merged 9 commits into
nuxt-community:master
from
andre-brdoch:netlify-toml
May 26, 2020
Merged
feat: programmatic netlify.toml support & copying #11
TheAlexLichter
merged 9 commits into
nuxt-community:master
from
andre-brdoch:netlify-toml
May 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 25 38 +13
Branches 2 5 +3
=========================================
+ Hits 25 38 +13
Continue to review full report at Codecov.
|
TheAlexLichter
changed the title
netlify.toml support
feat: programmatic netlify.toml support & copying
May 26, 2020
Well done! 👍🏻 |
Merged
thank you! |
@andre-brdoch Will bundle a release in the coming days 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would probably make sense to change the nuxt hook to
generate:distRemoved
, since certain things like env var might need to be accessible earlier on already. I just was not sure if there would be any downsides to this.This is my first time contributing to an open source project, and first time using conventional commit messages, so I hope I did things correctly :) feedback is very welcome
Resolves #4