Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: programmatic netlify.toml support & copying #11

Merged
merged 9 commits into from
May 26, 2020

Conversation

andre-brdoch
Copy link
Contributor

@andre-brdoch andre-brdoch commented May 23, 2020

  • copy netlify.toml from src to dist
  • alternatively create netlify.toml programmatically

It would probably make sense to change the nuxt hook to generate:distRemoved, since certain things like env var might need to be accessible earlier on already. I just was not sure if there would be any downsides to this.

This is my first time contributing to an open source project, and first time using conventional commit messages, so I hope I did things correctly :) feedback is very welcome

Resolves #4

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        38   +13     
  Branches         2         5    +3     
=========================================
+ Hits            25        38   +13     
Impacted Files Coverage Δ
lib/module.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 654fd78...f8c55c7. Read the comment docs.

lib/module.js Outdated Show resolved Hide resolved
@TheAlexLichter TheAlexLichter self-requested a review May 24, 2020 14:32
lib/module.js Outdated Show resolved Hide resolved
@TheAlexLichter TheAlexLichter changed the title netlify.toml support feat: programmatic netlify.toml support & copying May 26, 2020
@TheAlexLichter TheAlexLichter merged commit f9ab430 into nuxt-community:master May 26, 2020
@TheAlexLichter
Copy link
Member

Well done! 👍🏻

@andre-brdoch
Copy link
Contributor Author

thank you! ☺️ thanks for reviewing

@TheAlexLichter
Copy link
Member

@andre-brdoch Will bundle a release in the coming days 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Programmatically create _redirects file through JS objects
2 participants