fix(types): add types for process.sentry #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extending a namespace must be done in a definition file that has no top-level imports so that the file is treated as ambient module rather than a normal module. For that reason, I couldn't just put new code in `index.d.ts` but had to create separate file. Stuff from `index.d.ts` moved to `extend.d.ts` to have a cleaner structure.
|
@simllll feel free to have a look/review |
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 64.40% 64.40%
=======================================
Files 1 1
Lines 59 59
Branches 18 18
=======================================
Hits 38 38
Misses 17 17
Partials 4 4 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending a namespace must be done in a definition file that has no
top-level imports so that the file is treated as ambient module
rather than a normal module. For that reason, I couldn't just put new
code in
index.d.tsbut had to create separate file. Stuff fromindex.d.tsmoved toextend.d.tsto have a cleaner structure.