Update samples to use a computed variable for head #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Oct 9, 2020
pages/composition-api.vue
Outdated
Comment on lines
86
to
91
| title: 'Composition API Demo', | ||
| meta: [{ | ||
| name: 'message', | ||
| content: message.value // It's not reactive | ||
| }] | ||
| }) |
There was a problem hiding this comment.
@hmsk Sorry for the delay in replying. I'm afraid this isn't actually that intuitive at the moment. I might need to add the functionality to @nuxtjs/composition-api.
There was a problem hiding this comment.
Does this API look good to you?
There was a problem hiding this comment.
Makes sense for me. useMeta(() => ({})) is intuitive and looks similar to the type of head / head() in options/class API.
danielroe
added a commit
to nuxt-community/composition-api
that referenced
this pull request
Oct 9, 2020
* use like `useMeta(() => ({ title: message.value }))` for computed head
* nuxt-community/typescript-template#225
* closes #254
|
@hmsk my proposed api should now be useable in |
|
Thanks, @danielroe for your responsive updates on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useMeta(looks not supported yet)