Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to specify storage directory in development #112

Merged
merged 3 commits into from
May 21, 2024

Conversation

unibeck
Copy link
Contributor

@unibeck unibeck commented May 17, 2024

Resolves #111

@atinux atinux changed the title Fixes nuxt-hub/core#111 feat: option to specify storage directory in development May 21, 2024
@atinux atinux self-requested a review May 21, 2024 12:18
@atinux atinux merged commit f747892 into nuxt-hub:main May 21, 2024
3 of 4 checks passed
@atinux
Copy link
Contributor

atinux commented May 21, 2024

Merged and released in nightly build @unibeck

Can you try it (https://hub.nuxt.com/docs/getting-started/installation#nightly-builds) and confirm that it works?

The option is hub.dir now

@unibeck
Copy link
Contributor Author

unibeck commented May 21, 2024

Update: Nuxthub and wrangler dev (worker) are sharing the same dir, but they create their own DBs instead of reusing. I'll keep you posted on what I find
image

@unibeck
Copy link
Contributor Author

unibeck commented May 21, 2024

I got this to work!

After some debugging, wrangler creates those file names based on a hash of the binding id. So I just had to change my local worker's binding id to that of what nuxthub uses locally:
image

PR works as intended.

Copy link
Contributor

atinux commented May 22, 2024

Thanks for your feedback @unibeck ❤️

Aslemammad pushed a commit to Aslemammad/nuxt-core that referenced this pull request Jun 12, 2024
Co-authored-by: Sébastien Chopin <seb@nuxt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hub Storage Dir Config
2 participants