Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not throw errors during prepare script #168

Merged
merged 5 commits into from
Sep 25, 2023
Merged

fix: do not throw errors during prepare script #168

merged 5 commits into from
Sep 25, 2023

Conversation

Lehoczky
Copy link
Contributor

@Lehoczky Lehoczky commented Sep 5, 2023

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #153

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link
Collaborator

@Baroshem Baroshem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

I have added some comment for you to check out :)

package.json Show resolved Hide resolved
src/module.ts Outdated Show resolved Hide resolved
@Lehoczky Lehoczky changed the title fix: only show warnings during startup instead of throwing errors fix: do not throw errors during prepare script Sep 7, 2023
@Baroshem
Copy link
Collaborator

Hey @Lehoczky

Dont worry, I have not forgotten about you. I am currently focusing on releasing a major version of another module (security) so I am spending most of my time there. Once the new version will be released there, I will come back to you and to release 2.0.0 of Algolia ;)

@Baroshem Baroshem self-requested a review September 25, 2023 08:44
@Baroshem
Copy link
Collaborator

Hey, I have changed the base branch from main to chore/2.0.0-rc.1 :)

@Baroshem Baroshem changed the base branch from main to chore/2.0.0-rc.1 September 25, 2023 08:46
@Baroshem Baroshem merged commit 735b8f2 into nuxt-modules:chore/2.0.0-rc.1 Sep 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monorepo failures due to thrown errors
2 participants