-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to enable requester-fetch instead of requester-node-http for edge-environments like Cloudflare Workers #176
Add option to enable requester-fetch instead of requester-node-http for edge-environments like Cloudflare Workers #176
Conversation
✅ Live Preview ready!
|
Hey, thanks for this PR! I will take a look at it soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything good! Thanks for making this PR. Really nice work.
I wont be merging this PR yet As I would like to release a big new version soon 2.0.0 and this PR would fit right in there :)
Any updates on when 2.0.0 will be released? There is no way this can be merged as a minor version until then? |
Hey @vilhelmjosander I am planning to release the 2.0.0 next week. I was just very busy with Nuxt Security 1.0.0 release for the Nuxt Nation that is happening just now. If I wont make it to release 2.0.0 version next week, then I will release a minor version with this feature so that you could start using it :) |
Hey @vilhelmjosander I have changed the base branch from main to 1.10.0 and I want to release it this week. Could you please resolve the conflicts and remove the additional package-lock.json? Then I will merge it and release a new version with it :) |
@Baroshem Sorry for the late reply. I have fixed the merge conflicts and removed the package-lock.json. Make sure it looks ok then it should be ready to merge and release. |
@vilhelmjosander I will work on making the release today then. Thanks for your work! |
Types of changes
Description
This PR enables support for using this module in edge-environments which usually does not have access to nodes http module. Examples would be Cloudflare Workers or Vercel Edge (https://vercel.com/docs/functions/edge-functions/edge-runtime). By enabling
useFetch
in the configuration it will use @algolia/requester-fetch instead of @algolia/requester-node-http when process.server is true.Checklist: