-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: locale prefixes are not added to route aliases #2962
fix: locale prefixes are not added to route aliases #2962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Your PR look good me.
It depend on scanPageMeta
, but I am curious as to when it becomes GA feature. I seem that has performance issue. /cc @danielroe
If it does not become GA, we need to find out another solution.
I would like to make |
Good news! |
// overrides | ||
nuxtConfig: { | ||
experimental: { | ||
scanPageMeta: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think nuxt i18n should check the scanPageMeta
value and warn if it is false
.
Because, if that value changes to false
, nuxt i18n route aliases don't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just added a warning that logs when the feature is not enabled 8cab851
(#2962)!
π Linked issue
β Type of change
π Description
Resolves #2957
This adds locale prefixes to route aliases but requires the experimental
scanPageMeta
feature to be enabled to work, not entirely sure where in the docs would be appropriate to document this.π Checklist