Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure extend vue-i18n #3017

Merged

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Jul 5, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We still have some split logic between this module and what was originally in vue-i18n-routing, because of this we were extending vue-i18n in two places.

After some reorganizing I noticed that onExtendExportGlobal and onExtendVueI18n were actually doing the same thing but with different variable names πŸ€” possibly __composerExtend did the same as well, after merging and generalizing these extends it appears to still be working.

I feel like my changes should have broken something.. πŸ˜‚ Either the refactored code was interchangeable or it contains untested logic πŸ€”

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede force-pushed the refactor/restructure-extend-vue-i18n branch from 5672b82 to c6d41ea Compare July 10, 2024 07:32
@BobbieGoede BobbieGoede requested a review from kazupon July 10, 2024 11:24
@BobbieGoede BobbieGoede marked this pull request as ready for review July 10, 2024 12:01
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Refactoring!
Thank you always! ❀️

@kazupon kazupon merged commit 2887904 into nuxt-modules:main Jul 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants