Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in head.ts #572

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

DepkaCZ
Copy link
Contributor

@DepkaCZ DepkaCZ commented May 30, 2024

Hi,

found a typo in head.ts composable which causes:

Pre-transform error: Failed to resolve import "#vue-router" from "node_modules/@nuxtjs/ionic/dist/runtime/composables/head.mjs?v=ccfb2c39".

#vue-router -> vue-router
@DepkaCZ DepkaCZ requested a review from danielroe as a code owner May 30, 2024 14:46
Copy link

netlify bot commented May 30, 2024

Deploy Preview for friendly-lamington-fb5690 canceled.

Name Link
🔨 Latest commit c1c1cd6
🔍 Latest deploy log https://app.netlify.com/sites/friendly-lamington-fb5690/deploys/66589131ff90370008aed049

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.65%. Comparing base (b2bfe7e) to head (c1c1cd6).

Files Patch % Lines
src/runtime/composables/head.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   46.65%   46.65%           
=======================================
  Files          11       11           
  Lines         866      866           
  Branches       38       38           
=======================================
  Hits          404      404           
  Misses        462      462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe merged commit a6974f5 into nuxt-modules:main May 30, 2024
7 of 8 checks passed
@danielroe
Copy link
Collaborator

Thank you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants