Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support server-only (NuxtIsland) components #502

Merged
merged 8 commits into from
Aug 6, 2024
Merged

feat: support server-only (NuxtIsland) components #502

merged 8 commits into from
Aug 6, 2024

Conversation

P4sca1
Copy link
Contributor

@P4sca1 P4sca1 commented Jul 31, 2024

Closes #494

@vercel Vercel
Copy link

vercel bot commented Jul 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2024 0:10am

@P4sca1 P4sca1 mentioned this pull request Jul 31, 2024
Closed
@P4sca1
chore: fix typo
0e3ab07 
Signed-off-by: Pascal Sthamer <10992664+P4sca1@users.noreply.github.com>
@Baroshem
Copy link
Collaborator

Baroshem commented Aug 2, 2024

Hey there, thanks for this PR! Let's wait for @vejja to take a look at it and afterwards we could merge it :)

vejja
vejja reviewed Aug 2, 2024
View reviewed changes
src/runtime/nitro/plugins/40-cspSsrNonce.ts Outdated Show resolved Hide resolved
src/runtime/nitro/plugins/50-updateCsp.ts Outdated Show resolved Hide resolved
src/utils/island.ts Outdated Show resolved Hide resolved
@P4sca1
Replace isIslandRequest util with check if nonce already exist
57ff90b 
Signed-off-by: Pascal Sthamer <10992664+P4sca1@users.noreply.github.com>
@P4sca1
fix: use console warn instead of useLogger
1a5ada9 
Signed-off-by: Pascal Sthamer <10992664+P4sca1@users.noreply.github.com>
@P4sca1
Copy link
Contributor Author

P4sca1 commented Aug 3, 2024

@vejja @huang-julien I think I addressed all your concerns. Would be great if you could review again.

@vejja
Copy link
Collaborator

vejja commented Aug 3, 2024

LGTM
Thank you so much @P4sca1 for this.
The module now supports islands 🏝️
This is a great addition !

huang-julien
huang-julien approved these changes Aug 3, 2024
View reviewed changes
Copy link
Contributor

@huang-julien huang-julien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Baroshem Baroshem changed the base branch from main to chore/2.0.0 August 6, 2024 16:47
@Baroshem
Copy link
Collaborator

Baroshem commented Aug 6, 2024

Amazing work @P4sca1

Thank you! I will merge it know to 2.0.0 branch and prepare it for this release :)

@Baroshem Baroshem merged commit e6df1ac into nuxt-modules:chore/2.0.0 Aug 6, 2024
2 checks passed
@P4sca1
Copy link
Contributor Author

P4sca1 commented Aug 7, 2024

Thank you @Baroshem! Could you draft a new RC release?

@Baroshem
Copy link
Collaborator

Baroshem commented Aug 7, 2024 •
edited
Loading

I am planning to release 2.0.0 in the next few days :)

@P4sca1
Copy link
Contributor Author

P4sca1 commented Sep 2, 2024

@Baroshem It would be great if this SSR fix could be released. If not as 2.0.0 then maybe as another RC release?

@Baroshem
Copy link
Collaborator

Baroshem commented Sep 9, 2024

@P4sca1

Yes, sorry but I was on long holidays and couldn't work on it. I expect to release 2.0.0 this week :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vejja vejja vejja left review comments

@huang-julien huang-julien huang-julien approved these changes

@Baroshem Baroshem Baroshem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nonce is missing when rendering a <NuxtIsland> component during SSR
4 participants
@P4sca1 @Baroshem @vejja @huang-julien