Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore invalid values on image discovery #290

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

rayblair06
Copy link
Contributor

@rayblair06 rayblair06 commented Jun 26, 2024

πŸ”— Linked issue

Resolves #289

N/A

❓ Type of change

  • [] πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Exclude <img> src values such as blob:, file:, and data: from Image Discovery.

@rayblair06 rayblair06 changed the title chore: ignore invalid values on image discovery fix: ignore invalid values on image discovery Jun 26, 2024
@harlan-zw
Copy link
Collaborator

Great catch, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image discovery can pull valid src values but invalid image:loc values such as data:, blob:, or file:
2 participants