fix: fix TypeError when reading '__STORYBOOK__' property of undefined

[baixiaoyu2997]

Close: #538

[netlify]

👷 Deploy request for nuxt-storybook pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	f055891

[NRodriguezcuellar]

To not switch back i think it would be better to use optional chaining to prevent errors when an env is not defined

import.meta.env?.__STORYBOOK__

[tobiasdiez]

To not switch back i think it would be better to use optional chaining to prevent errors when an env is not defined

import.meta.env?.__STORYBOOK__

I think this is indeed the better solution. @baixiaoyu2997 could you please give this a try?

[baixiaoyu2997]

To not switch back i think it would be better to use optional chaining to prevent errors when an env is not defined

import.meta.env?.__STORYBOOK__

I think this is indeed the better solution. @baixiaoyu2997 could you please give this a try?

sorry, i don't understand, for my understanding import.meta.env?.__STORYBOOK__ always be undefined, because process.env is not equal to import.meta.env

[NRodriguezcuellar]

It is not exactly the same but serves the same purpose and has some security benefits when using Vite, you can read about it on here:

• https://storybook.js.org/docs/configure/environment-variables#with-vite
• https://vitejs.dev/guide/env-and-mode

[tobiasdiez]

Yes,

storybook/src/storybook.ts

Line 104 in 67ff54e

process.env.__STORYBOOK__ = JSON.stringify( options )

needs to be changed as well to use import.meta.env

[baixiaoyu2997]

thanks, guys, test on local, build success

[NRodriguezcuellar]

Great! Small typo in the title by the way 😃

[cannap]

at checkExecSyncError (node:child_process:887:11)
at execSync (node:child_process:959:15)
at Object.run (/C:/Users/von%20mir/Desktop/offline-sync-demo/node_modules/nuxi/dist/chunks/upgrade.mjs:100:5)
at async runCommand$1 (/C:/Users/von%20mir/Desktop/offline-sync-demo/node_modules/nuxi/dist/shared/nuxi.9edf0930.mjs:1648:16)
at async runCommand$1 (/C:/Users/von%20mir/Desktop/offline-sync-demo/node_modules/nuxi/dist/shared/nuxi.9edf0930.mjs:1639:11)
at async runMain$1 (/C:/Users/von%20mir/Desktop/offline-sync-demo/node_modules/nuxi/dist/shared/nuxi.9edf0930.mjs:1777:7)

i get the same is use bun on windows

{
  "name": "nuxt-app",
  "private": true,
  "type": "module",
  "scripts": {
    "build": "nuxt build",
    "dev": "nuxt dev",
    "start": "node .output/server/index.mjs",
    "generate": "nuxt generate",
    "preview": "nuxt preview",
    "studio": "bunx drizzle-kit studio",
    "postinstall": "nuxt prepare"
  },
  "dependencies":  {
    "dotenv": "^16.4.5",
    "drizzle-orm": "^0.30.8",
    "lucia": "^3.1.1",
    "nuxt": "^3.11.2",
    "oslo": "^1.2.0",
    "pg": "^8.11.5",
    "postgres": "^3.4.4",
    "vue": "^3.4.21",
    "vue-router": "^4.3.0"
  },
  "devDependencies": {
    "@nuxt/devtools": "^1.2.0",
    "@nuxt/eslint": "^0.3.8",
    "@nuxtjs/storybook": "^8.0.0",
    "@nuxtjs/tailwindcss": "^6.12.0",
    "@types/pg": "^8.11.5",
    "@vite-pwa/nuxt": "^0.6.0",
    "@vueuse/nuxt": "^10.9.0",
    "drizzle-kit": "^0.20.16",
    "eslint": "^9.1.0"
  }
}

[9mm]

when will this be released?

[AdamovichArtur]

Any ideas when the fixes will be released?

[chakAs3]

it is released sorry for the delay : https://github.com/nuxt-modules/storybook/releases/tag/v8.1.1