-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add enabled option #612
feat: add enabled option #612
Conversation
👷 Deploy request for nuxt-storybook pending review.Visit the deploys page to approve it
|
Good idea, this would also resolve #555, right? I'm not so sure about the name of the option. Currently, the module indeed only starts the storybook server - but that may change in the future. So I would prefer a name that reflects that only the storybook dev server can be disabled by this option. Tailwind has it under viewer. Maybe just also use |
oh indeed. |
Okay, if more fine-grained control is needed in the future, we can add another Could you please add a short description of the option to https://github.com/nuxt-modules/storybook/blob/main/docs/content/1.getting-started/2.options.md (perhaps with your use case of layers as motivation). Otherwise this looks good from my side. |
Thanks! |
Fixes #555 and fixes storybook-vue/storybook-nuxt#63.
Hi 👋 this PR adds an
enabled
option.This can be useful for layers.
Some users have project A, B with A extending B that has storybook but is not needed in A. This can improve dev server startup as storybook can be quite heavy to load on bigger projects.