Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: indicate compatibility with new v4 major #645

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Conversation

danielroe
Copy link
Collaborator

With Nuxt 4 on the horizon, this updates the module compatibility definition to allow it to be installed on Nuxt v4. (Otherwise Nuxt will indicate the module might not be compatible.)

When Nuxt v4 comes out then you might decide or need to make breaking changes in this module and release a new major, but hopefully the migration should be smoother. 🙏

👉 You can follow this and other changes in nuxt/nuxt#27613 - please feel free to provide feedback as well!

Copy link

netlify bot commented Jun 14, 2024

Deploy Preview for nuxt-storybook ready!

Name Link
🔨 Latest commit d5fed11
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-storybook/deploys/666c440f36fadd0008bcaada
😎 Deploy Preview https://deploy-preview-645--nuxt-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tobiasdiez
Copy link
Collaborator

Thanks @danielroe!

Since the storybook module integrates quite closely to nuxt internals (eg. we copy and modify nuxt's vite config), it is very likely that we are not compatible with v4 without further changes. Would you still recommend to add the compatibility tag?

Otherwise Nuxt will indicate the module might not be compatible.

I feel this might be more honest to the devs that are using the storybook module but are trying out nuxt v4.

@danielroe
Copy link
Collaborator Author

danielroe commented Jun 15, 2024

I would suggest testing with the new compatibility version: https://nuxt.com/docs/getting-started/upgrade#testing-nuxt-4.

Although we haven’t released v4 yet, this gives a good initial indication.

(For me, there were no red flags for this module in our change log, but obviously testing is safest.)

@tobiasdiez
Copy link
Collaborator

I've tested the v4 future flag over at #648 and it seems that there are indeed no problems. Awesome to see that migration to v4 will be much smoother than v2>v3, also thanks to your proactive PRs in modues.

So let's get this in.

@tobiasdiez tobiasdiez merged commit c40a4dd into main Jun 15, 2024
14 checks passed
@tobiasdiez tobiasdiez deleted the v4-compatibility branch June 15, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants