Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linter and update lock file #686

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

tobiasdiez
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Fixes the linter, and revert back to lockfile vs 9.

Copy link

netlify bot commented Jul 10, 2024

πŸ‘· Deploy request for nuxt-storybook pending review.

Visit the deploys page to approve it

Name Link
πŸ”¨ Latest commit 16675ce

@tobiasdiez tobiasdiez requested a review from chakAs3 July 10, 2024 18:46
@tobiasdiez
Copy link
Collaborator Author

This partly reverts #684. @chakAs3 not sure what issue you tried to fix with this PR. Does this PR here reintroduces it for you?

Copy link
Collaborator

@chakAs3 chakAs3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having issues with dependency installation for "nuxt" and "vue". It seems I have two different versions: the latest in the root node_modules and an older version in the storybook-addon package.

I'm confused about managing the versions for the Nuxt module package and the Storybook addon. Should we release them separately with different versions, or should we use a single version for both in each release? Would you help me understand your release strategy?

Additionally, I can't see the playground to test @storybook-vue/nuxt independently. There's only one playground to test the module that has @storybook-vue/nuxt as a dependency.

@tobiasdiez
Copy link
Collaborator Author

I'm having issues with dependency installation for "nuxt" and "vue". It seems I have two different versions: the latest in the root node_modules and an older version in the storybook-addon package.

If you run pnpm install in the root it should use whatever version is specified in the lock file, which is the latest version (compatible with the constraints). Try to delete all node_modules folders and then run install again. It also seems that your version of pnpm is quite old.

I'm confused about managing the versions for the Nuxt module package and the Storybook addon. Should we release them separately with different versions, or should we use a single version for both in each release? Would you help me understand your release strategy?

This still comes from the times where we had two different repos (and hence no version alignment). I agree a consistent version requirement would make sense.

Additionally, I can't see the playground to test @storybook-vue/nuxt independently. There's only one playground to test the module that has @storybook-vue/nuxt as a dependency.

I moved most of the @storybook-vue/nuxt playground to examples/showcase so that it can be automatically tested with chromatic. I don't really see the need to have a @storybook-vue/nuxt-only test space since the nuxt module just facilitates the development - but if you feel that would be helpful for debugging, we can add another example that uses this package directly.

@chakAs3
Copy link
Collaborator

chakAs3 commented Jul 11, 2024

Thanks, @tobiasdiez. I’ll try again with the dependencies. Even though I always run git clean -xdf to clear my local files and manually remove all node_modules, the lockfile is still causing issues for me.

I will merge this PR then release properly this time ok ?

@chakAs3 chakAs3 merged commit a6d95d6 into nuxt-modules:main Jul 11, 2024
9 of 10 checks passed
@tobiasdiez tobiasdiez deleted the fix-ci branch July 11, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants