Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linting warnings #687

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jul 11, 2024

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR fixes the linting warnings:

  • overrides the vue/html-self-closing rule because there are a lot of self-closing tags in the playground
  • adds a --max-warning=0 setting to eslint to ensure that the errors are not lost within the warnings
  • removes unused props and sets the default values for props in the playground
  • runs prettier --fix

Copy link

netlify bot commented Jul 11, 2024

πŸ‘· Deploy request for nuxt-storybook pending review.

Visit the deploys page to approve it

Name Link
πŸ”¨ Latest commit 9fffeae

@chakAs3 chakAs3 requested a review from tobiasdiez July 11, 2024 08:33
@obulat obulat force-pushed the fix/eslint-prettier-problems branch from 593991d to 2ba9817 Compare July 11, 2024 08:34
@tobiasdiez
Copy link
Collaborator

Thanks!

Concerning

overrides the vue/html-self-closing rule because there are a lot of self-closing tags in the playground

Do you know what the "correct" way of handling (non-)self-closing tags are, such that also prettier and eslint are both happy?

@tobiasdiez tobiasdiez merged commit 627527e into nuxt-modules:main Jul 11, 2024
10 checks passed
@obulat obulat deleted the fix/eslint-prettier-problems branch July 12, 2024 03:23
@tobiasdiez
Copy link
Collaborator

tobiasdiez commented Jul 12, 2024

Just saw that with these changes the "Custom components" in the showcase example are no longer rendered (in chromatic). See https://6631ee564bb0d0abcd38eb0f-exelvpgdgl.chromatic.com/?path=/story/features-custom-components--simple-component

I don't have the time right now to investigate this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants