Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support stylelint v16 with vite-plugin-stylelint v5 #109

Merged
merged 5 commits into from
Jan 29, 2024

Conversation

brownsugar
Copy link
Contributor

@brownsugar brownsugar commented Dec 24, 2023

This PR:

Use in Nuxt app:

Before After

Snipaste_20231224235514258

Snipaste_20231225000134384

@brownsugar
Copy link
Contributor Author

@ricardogobbosouza would you mind to take a review on this? Thanks!

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8924a55) 89.87% compared to head (0c19c7e) 86.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   89.87%   86.74%   -3.13%     
==========================================
  Files           2        3       +1     
  Lines          79       83       +4     
  Branches        9       10       +1     
==========================================
+ Hits           71       72       +1     
- Misses          8       10       +2     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricardogobbosouza ricardogobbosouza changed the title feat: Support Stylelint v16 with vite-plugin-stylelint v5 feat: support stylelint v16 with vite-plugin-stylelint v5 Dec 28, 2023
@ricardogobbosouza ricardogobbosouza self-requested a review January 2, 2024 13:53
Copy link
Collaborator

@ricardogobbosouza ricardogobbosouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @brownsugar
Just a detail that we still don't have stylelint support using webpack webpack-contrib/stylelint-webpack-plugin#342

Maybe mention this in the documentation

@brownsugar
Copy link
Contributor Author

@ricardogobbosouza Sure, just added the note for version support.

@brownsugar brownsugar force-pushed the stylelint-v16-support branch from 1771a80 to bc62b07 Compare January 3, 2024 07:53
@brownsugar
Copy link
Contributor Author

Hi @ricardogobbosouza, any update for this?

@magway
Copy link

magway commented Jan 22, 2024

bump

1 similar comment
@Endermanch
Copy link

bump

@ricardogobbosouza ricardogobbosouza merged commit 61b4957 into nuxt-modules:main Jan 29, 2024
2 of 3 checks passed
@brownsugar
Copy link
Contributor Author

Hi @ricardogobbosouza can you make a release for recent changes?

@ricardogobbosouza
Copy link
Collaborator

Released https://github.com/nuxt-modules/stylelint/releases/tag/v5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stylelint v16
4 participants