fix(icons-page): prevent file not found error #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @farnabaz Could you take a look on this? |
|
Using set timeout is hacky and this may fail in large projects. I'm going to change this part a little. |
|
Yep, it is hakcy but Settimeout wil be called recursively ultil the file is created so i think it is safe in this way, but your fix is better, please merge it soon :D |
farnabaz
changed the title
|
Thank you |
This was referenced Sep 2, 2020
Merged
farnabaz
added a commit
that referenced
this pull request
Sep 2, 2020
Co-authored-by: Farnabaz <farnabaz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nuxt-community#120
Check if nuxt-svg-sprite-icons-list.vue is existing then call extendRoutes else re-try