feat: providing types for all exports #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atinux
changed the title
|
Would love to get a review from @danielroe as being the TS master 😄 |
✅ Live Preview ready!
|
danielroe
reviewed
Mar 12, 2023
Co-authored-by: Daniel Roe <daniel@roe.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #583.
Features:
Needs discussion:
PR awaits fix: nested props resolution #616nuxt.d.tsreferences - Done, but please let me know if there's another way the types can be referred#tailwind-configalias resolution - Done, not going for alias but only allowing#tailwind-configsince that's encouraged by docs and.nuxt/tailwind.config...could get tricky depending on file/directory location; also updated docs accordinglydst- Not needed if step above is omittedcurrently using hardcoded.nuxt/tailwind.configas safety, but obviously only to demo the workimplementation is as fallback to the hardcoded demo eg|| t.dstProviding a playground to test changes: https://stackblitz.com/github/ineshbose/nuxt-tailwindcss-module/tree/feat/types (although I don't think Stackblitz gives quick TypeScript intellisense)