Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quiet mode #702

Closed
wants to merge 1 commit into from
Closed

feat: add quiet mode #702

wants to merge 1 commit into from

Conversation

JohnCampionJr
Copy link

@JohnCampionJr JohnCampionJr commented Jul 6, 2023

closes: #527
Defaults to false as to be a non-breaking change

Defaults to false as to be a non-breaking change
@what-the-diff
Copy link

what-the-diff bot commented Jul 6, 2023

PR Summary

  • Quieter Operations in Playground Mode
    The setting configuration in playground mode has been updated to be quieter, meaning it will generate less log outputs. This results in a less cluttered output for developers, making it easier to spot important information.

  • New Default Value for Quiet Operation in Module
    In the module settings, the function that sets the default values now includes a 'quiet' property set to false. This offers the flexibility for developers to choose quieter operation if desired.

  • Conditional Logging in resolveCSSPath Function
    The resolveCSSPath function, which is used for handling CSS, now only outputs logs when quiet mode is off. This means that we'll have cleaner, more streamlined logs without unwanted noise.

  • Conditional Function Calling in setupViewer Function
    The setupViewer function is integral to the operation of the module. This function has been adjusted, it now only calls the setupViewer function when project is not in quiet mode and viewer is not off, making operation smoother and less noisy.

  • Inclusion of New Property in ModuleOptions Interface
    To accommodate the above updates, the 'quiet' property has been added to the ModuleOptions interface. This means you can specify whether you want quiet mode when setting up module options.

  • Introduction of Quiet Parameter and Conditional Logging in Viewer Function
    Lastly, a new parameter of quiet has been included with a default value of false in the viewer function. The logging in this viewer function is now conditionally logged based on whether quiet mode is on or not. This addition gives users control over logging verbosity when using the viewer.

@JohnCampionJr
Copy link
Author

Any chance of getting this merged?

@ineshbose ineshbose changed the title feat: add quiet mode (#527) feat: add quiet mode Jul 26, 2023
@ineshbose
Copy link
Collaborator

@atinux - thoughts?

@@ -8,7 +8,8 @@ export default defineNuxtConfig({
tailwindcss: {
// viewer: false,
exposeConfig: true,
injectPosition: 'last'
injectPosition: 'last',
quiet: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, could you update @JohnCampionJr ?

@jpsc jpsc mentioned this pull request Oct 19, 2023
@ineshbose
Copy link
Collaborator

Going to close this for the same reason as this - #732 (comment). If there's demand, we can look into this again! Thank you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to remove logging of tailwind CSS location
4 participants