Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add types to package.json exports map #724

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

stefanprobst
Copy link
Contributor

when using ts with "module": "nodenext" / "bundler", the types field is expected on exports in package.json.

@what-the-diff
Copy link

what-the-diff bot commented Sep 23, 2023

PR Summary

  • Introduction of TypeScript Types
    The update in the package.json file includes the addition of a new property, specifically for TypeScript types. This change means our code is now more robust and less error-prone, improving the quality of our application. This property points to a file that holds these type definitions, making it easier for developers to understand the structure and objects they're working with.

@pi0
Copy link
Contributor

pi0 commented Sep 26, 2023

LGTM btw Have you tried checked package with https://arethetypeswrong.github.io/ ?

@stefanprobst
Copy link
Contributor Author

Have you tried checked package with https://arethetypeswrong.github.io/ ?

haven't heard of that before, thanks for the link!

@ineshbose
Copy link
Collaborator

Good spot - thank you! 😄

@ineshbose ineshbose merged commit f5b7c75 into nuxt-modules:main Oct 20, 2023
@stefanprobst stefanprobst deleted the patch-1 branch October 20, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants