Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement fixes on viewer and allow exporting #754

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Conversation

ineshbose
Copy link
Collaborator

@ineshbose ineshbose commented Nov 5, 2023

closes #706
addresses #561

(doesn't work for SSG yet) nevermind, the playground has some issues on this, but let's ship and get feedback

*
* @default false
*/
exportViewer: boolean;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was using property as export before, but it might conflict with JS keyword

@ineshbose ineshbose marked this pull request as ready for review November 9, 2023 11:45
@ineshbose ineshbose changed the title feat(viewer): allow exporting chore: implement fixes on viewer and allow exporting Nov 9, 2023
@atinux atinux merged commit 1769e6a into main Nov 15, 2023
4 checks passed
@atinux
Copy link
Collaborator

atinux commented Nov 15, 2023

Could you open a PR for the docs once I publish the new docs @ineshbose ?

@atinux atinux deleted the feat/export-viewer branch November 15, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable exporting the statically-rendered config viewer
2 participants