fix: do not override preset when prerendering

[BobbieGoede]

🔗 Linked issue

• Nuxt generate doesn't respect NITRO_PRESET #555

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality)
• ✨ New feature (a non-breaking change that adds functionality)
• 🧹 Chore (updates to the build process or auxiliary tools and libraries)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Related to #555, possibly resolves it?

We currently override any configured preset with static, instead we should let nitro resolve the appropriate preset by passing static: true since it supports several static presets.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@2d61aa1). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
src/commands/build.ts	0.00%	5 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##             main    #605   +/-   ##
======================================
  Coverage        ?   1.31%           
======================================
  Files           ?      44           
  Lines           ?    2894           
  Branches        ?      44           
======================================
  Hits            ?      38           
  Misses          ?    2815           
  Partials        ?      41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danielroe]

in fact this is still not quite right - there are several static presets, including vercel-static, netlify-static, and so on, and we probably need to ignore (that is, not log warnings) for any static preset that's passed

[BobbieGoede]

It looks like nitro tries to infer the correct static preset based on the value of preset when static: true (nitrojs/nitro#2860) it's undocumented though (nitrojs/nitro#1524). I just removed the logging and only fall back to static preset if none is provided during prerender, is this what you had in mind?

[danielroe]

we should not set the static preset but instead pass static: true

you can test by setting (for example) NETLIFY=1 nuxi build --prerender - we want it in that case to use netlify-static preset.

[BobbieGoede]

Okay I think/hope I finally understand, I removed the overriding of the preset variable and now log the resolved nitro preset instead.