Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: navigation dir confs handle missing query params #2772

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix: navigation dir confs handle missing query params #2772

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ace425
fix: navigation dir confs handle missing query params
hi-zp Sep 8, 2024
d37dbdc
fix(navigation): extract locale from query and use it in configs query
farnabaz Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/server/api/navigation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default defineEventHandler(async (event) => {
})
.find()

const dirConfigs = await serverQueryContent(event)
const dirConfigs = await serverQueryContent(event, query)
.where({ _path: /\/_dir$/i, _partial: true })
.find()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using user's query in configs search might result in loosing some configs. Imagine user filter documents based on their path or title.

What if we use first retrieved content to get the locale and use it in configs query?

const dirConfigs = await serverQueryContent(event, contents.length ? { _locale: contents[0]._length } : {})
    .where({ _path: /\/_dir$/i, _partial: true })
    .find()


Expand Down
Loading