-
-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: import defineNitroPlugin from #imports instead of nitropack/runtime #2787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Hey @farnabaz any plans on creating a hotfix release for this? |
Kindly asking if this will be released any time soon? I cant deploy most of the apps that use this module because of this error. |
Hey there, |
Thanks. Appreciate it |
What is the root cause? In my case, I can't avoid it with import { useRequestBody } from "nitropack/runtime/utils"; It's not work: import { useRequestBody } from "#imports"; |
This is my first PR- but this bug has been bugging me for a few weeks now, and I'm not sure if I have some unique setup that causes the error, but this is blocking me from doing pretty much anything- so I figured I'd give it a shot!
I am not sure the best way to go about testing this- but I am essentially cargo-culting the solution from nuxt/icon and hoping this can be solved in the same way- let me know how to best support/test/finish this off and I will do my best
🔗 Linked issue
MIGHT SOLVE #2736
Related:
❓ Type of change
I tried the mirror the changes from
nuxt/icon
in this commit: https://github.com/nuxt/icon/pull/249/files📚 Description
In the previous version,
defineNitroPlugin
was imported fromnitropack/runtime
- this instead uses#imports
Currently when running
yarn dev
with latest Nuxt / Nuxt Content, I get this:which prevents both publishing and development
📝 Checklist