fix(content): Offline mode #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barbapapazes
changed the title
benjamincanac
changed the title
|
@Barbapapazes Really nice PR! Just need to fix the tests and it will be good to go 🙂 |
|
Tests are ok ! |
benjamincanac
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue when using app in SPA mode. The DB wasn't call correctly (using a
Date.now()which makes unusable offline mode)Types of changes
Description
It resolve #229 ! Using a env in the runtimeConfig and passing it to the static plugin, the value is the same during the app is alive but change when there is a new build !
Maybe I can use a key generation but don't kwon how !
Checklist: