Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-docs): allow overriding theme components #963

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

nozomuikuta
Copy link
Collaborator

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #328.

I believe this PR takes the simplest approach.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

I tested overriding components with this change in my local.

@nozomuikuta nozomuikuta requested a review from pi0 September 13, 2021 04:23
@nozomuikuta nozomuikuta added the bug Something isn't working label Sep 22, 2021
@@ -114,7 +114,7 @@ const defaultConfig = docsOptions => ({
'@nuxt/content'
],
components: [
{ path: '~/components', pathPrefix: false }
{ path: '~/components', pathPrefix: false, level: 1 }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should normally be set when extending the base theme but currently we not using nuxt-extend so lets' have it :)

@pi0 pi0 changed the title fix(theme-docs): reorder default components dir fix(theme-docs): allow overriding theme components Oct 21, 2021
@pi0 pi0 merged commit 1f4a5d2 into nuxt:main Oct 21, 2021
@nozomuikuta nozomuikuta deleted the fix/overriding-components branch October 21, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@nuxt/content-theme-docs] Override default components
2 participants