Skip to content

Commit

Permalink
fix(prettier): use recommended rules to avoid eslint conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
scscgit committed Aug 23, 2021
1 parent 4950578 commit 5f05d22
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/cna-template/template/_.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module.exports = {
<%_ } _%>
'plugin:nuxt/recommended',
<%_ if (prettier) { _%>
'prettier'
'plugin:prettier/recommended'
<%_ } _%>
],
plugins: [
Expand Down
3 changes: 3 additions & 0 deletions packages/cna-template/template/nuxt/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ module.exports = {
delete pkg.devDependencies['stylelint-config-standard']
delete pkg.devDependencies['stylelint-config-prettier']
}
if (!eslint || !prettier) {
delete pkg.devDependencies['eslint-plugin-prettier']
}
if (!prettier) {
delete pkg.devDependencies['eslint-config-prettier']
delete pkg.devDependencies['stylelint-config-prettier']
Expand Down
1 change: 1 addition & 0 deletions packages/cna-template/template/nuxt/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"eslint": "^7.32.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-nuxt": "^2.0.0",
"eslint-plugin-prettier": "^3.4.1",
"eslint-plugin-vue": "^7.16.0",
"husky": "^6.0.0",
"lint-staged": "^10.5.4",
Expand Down
1 change: 1 addition & 0 deletions packages/create-nuxt-app/test/snapshots/index.test.js.md
Original file line number Diff line number Diff line change
Expand Up @@ -2099,6 +2099,7 @@ Generated by [AVA](https://avajs.dev).
eslint: '^7.32.0',
'eslint-config-prettier': '^8.3.0',
'eslint-plugin-nuxt': '^2.0.0',
'eslint-plugin-prettier': '^3.4.1',
'eslint-plugin-vue': '^7.16.0',
husky: '^6.0.0',
'lint-staged': '^10.5.4',
Expand Down
Binary file modified packages/create-nuxt-app/test/snapshots/index.test.js.snap
Binary file not shown.

0 comments on commit 5f05d22

Please sign in to comment.