Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

feat(vuetify): use vuetify module #225

Merged
merged 15 commits into from
May 30, 2019
Merged

feat(vuetify): use vuetify module #225

merged 15 commits into from
May 30, 2019

Conversation

lv-kit
Copy link
Contributor

@lv-kit lv-kit commented Apr 29, 2019

I want to change it to use vuetify files for nuxt.
I thought it would be easier for developers to manage one plug-in.

  • Change to vuetify module for nuxt
  • Add error layout

@lv-kit lv-kit changed the title change vuetify base plugin change vuetify plugin Apr 29, 2019
@pi0 pi0 changed the title change vuetify plugin feat(vuetify): use vuetify module May 13, 2019
@robsontenorio
Copy link

Looks great!

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (as a non vuetify expert)

@clarkdo
Copy link
Member

clarkdo commented May 30, 2019

@takehiro-takahashi Could you please fix the conflicts/tests and revert yarn.lock ?

@pi0 pi0 requested a review from clarkdo May 30, 2019 11:39
@clarkdo clarkdo merged commit 1c8d944 into nuxt:master May 30, 2019
@clarkdo
Copy link
Member

clarkdo commented May 30, 2019

@takehiro-takahashi Thanks!

@emelendez
Copy link

Fresh install now doesn't work!!!
\nuxt.config.js
68:16 error 'colors' is not defined no-undef
69:15 error 'colors' is not defined no-undef
70:18 error 'colors' is not defined no-undef
71:13 error 'colors' is not defined no-undef
72:16 error 'colors' is not defined no-undef
73:14 error 'colors' is not defined no-undef
74:16 error 'colors' is not defined no-undef

✖ 7 problems (7 errors, 0 warnings)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! zf-acs@1.0.0 lint: eslint --ext .js,.vue --ignore-path .gitignore . "--fix"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the zf-acs@1.0.0 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@clarkdo
Copy link
Member

clarkdo commented Jun 6, 2019

I’ll propose a fix shortly

@clarkdo
Copy link
Member

clarkdo commented Jun 6, 2019

@emelendez v2.7.1 released

@lv-kit lv-kit deleted the feature/change-vuetify-base-plugin branch January 10, 2020 04:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants