-
-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vuetify): updated layout to be on par with vuetify 2.x #619
Conversation
LGTM. One leftover is to change the snapshots so the tests are matching. |
hi. I tried but I'm unable to figure out how to start on fixing the snapshots. Can you shine a light on this? I don't have prior experience with PR. I do know that snapshot is like an image frame of a video. Should I be doing a git pull to fix this? |
@manniL Sorry for the 3 days gap (I had the discord browser closed). I appreciate your help. Since I didn't install jest, I saw that I can run it with I am getting some error messages on all the above directories so I'm guessing I don't know which directory I should be on. |
Hey 👋🏻 |
…rectory, then run the script for est:snap.
…epository checks. This is from root
With your help I'm able to pass the However, the new commit fails the snapshot check here in the remote. I checked that I'm on the Sadly, the 2 test failures are still here. Also, it automatically updated |
v-row is a wrapper component for v-col. It utilizes flex properties to control the layout and flow of its inner columns. [...] This is the 2.x replacement for v-layout in 1.x.
v-col is a content holder that must be a direct child of v-row. This is the 2.x replacement for v-flex in 1.x.
https://vuetifyjs.com/en/components/grids/#usage
Related: #597