fix(nuxt): allow overriding lower layer composables #10017

danielroe · 2023-01-09T16:01:52Z

📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality like performance)
✨ New feature (a non-breaking change that adds functionality)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

This PR adds a priority to composables scanned from directories so that higher priority layers can override lower priority layers.

codesandbox · 2023-01-09T16:01:58Z

packages/nuxt/src/imports/module.ts

fix(nuxt): allow overriding lower layer composables

e7b4d05

danielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jan 9, 2023

danielroe requested a review from antfu January 9, 2023 16:01

danielroe self-assigned this Jan 9, 2023

pi0 reviewed Jan 9, 2023

View reviewed changes

packages/nuxt/src/imports/module.ts Outdated Show resolved Hide resolved

pi0 reviewed Jan 9, 2023

View reviewed changes

packages/nuxt/src/imports/module.ts Show resolved Hide resolved

fix: use negative priorities to allow user overriding

477e000

danielroe merged commit bf649fe into main Jan 14, 2023

danielroe deleted the fix/override-composables branch January 14, 2023 01:14

danielroe added the 3.x label Jan 19, 2023

danielroe mentioned this pull request Jan 20, 2023

v3.1.0 nuxt/nuxt#18406

Merged

danielroe added a commit that referenced this pull request Jan 21, 2023

fix(nuxt): allow overriding lower layer composables (#10017)

ca103c5

Provide feedback