Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat: composables import path #10084

Closed
wants to merge 3 commits into from
Closed

feat: composables import path #10084

wants to merge 3 commits into from

Conversation

ineshbose
Copy link
Member

πŸ”— Linked issue

nuxt/nuxt#12414

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Added 'composables/*/index.{ts,js,mjs,mts}' to composable imports to scan the same way as plugins/

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Jan 13, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@ineshbose ineshbose changed the title refactor: composables import path feat: composables import path Jan 13, 2023
@danielroe
Copy link
Member

Here's some context: #6025.

@ineshbose
Copy link
Member Author

ineshbose commented Jan 13, 2023

Thanks for linking the previous discussion(s). I see nuxt/nuxt#14358 open as well in that regard, so the planned approach instead is for plugins/ to only scan top level. Up to you to close this!

Edit: #10090 for plugins/

@danielroe danielroe added 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing 3.x enhancement New feature or request and removed enhancement New feature or request labels Jan 14, 2023
@ineshbose ineshbose closed this Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants