This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1k
docs: update nested router example #10115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Β Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
FenLiaoYu
changed the title
Fix the description of
docs: fix the description of Jan 16, 2023
Using a Nested Router
Using a Nested Router
danielroe
reviewed
Jan 16, 2023
danielroe
reviewed
Jan 16, 2023
danielroe
reviewed
Jan 16, 2023
danielroe
reviewed
Jan 16, 2023
danielroe
reviewed
Jan 16, 2023
danielroe
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
danielroe
changed the title
docs: fix the description of
docs: update nested router example
Jan 16, 2023
Using a Nested Router
Merged
danielroe
pushed a commit
that referenced
this pull request
Jan 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#13696
β Type of change
π Description
Use
eventHandler()
to wrap the route handlerIn the latest release of
h3
, we should useeventHandler
to wrap our handlers.https://github.com/unjs/h3/releases/tag/v0.8.0
Fix error:
Invalid lazy handler result. It should be a function
We should return a handler function, not a
Router
, userouter.handler
oruseBase
can fix it.In this case, I think it should be
useBase('/api', router.handler)
π Checklist