-
-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(webpack): set extractCSS: true
by default
#4388
Conversation
β Deploy Preview for nuxt3-docs canceled.
|
pending: There is a chance we can fix the problem of CSS inlining. |
Looking at pi0/vue-loader@22894fe, this is not sufficient to enable us to inline styles, and we're already able to identify CSS files to preload when I would suggest we merge this PR, as vite isn't inlining styles either. Then we can look to add a new feature to both vite + webpack later to inline critical CSS later on. wdyt @pi0? |
we should really have a normalized options type
It's not worked when I used vite , I am confused |
Vite extracts CSS by default. You can turn off inlining styles by setting (In future please create a new issue rather than commenting on an old issue.) |
π Linked issue
nuxt/nuxt#11986
β Type of change
π Description
vue-loader
no longer supports extracting styles withvue-style-loader
- see vuejs/vue-style-loader#56.This PR removes the dependency and sets
extractCSS
to true by default (which is recommended in any case for production by webpack). If we are not able to inline styles then this is likely a better default, though it will be a breaking change when we re-introducevue-style-loader
later on.π Checklist