Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): await for router.push on ssr #4491

Merged
merged 2 commits into from
Apr 22, 2022
Merged

fix(nuxt): await for router.push on ssr #4491

merged 2 commits into from
Apr 22, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Apr 21, 2022

πŸ”— Linked issue

Fix nuxt/nuxt#13379

The server crashes because of uncaught promise rejection.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Apr 21, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 45e3f77
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/626130f20f6f3b00083e6f68

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks ❀️

@pi0 pi0 changed the title fix: await for router.push on SSR fix(nuxt): await for router.push on ssr Apr 22, 2022
@pi0 pi0 merged commit 46ecbc5 into main Apr 22, 2022
@pi0 pi0 deleted the fix/await-for-router-push branch April 22, 2022 15:37
@pi0 pi0 mentioned this pull request May 2, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

abortNavigation("message") crashes server when triggered on inital page load
4 participants