This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
feat(pages)!: explicitly allow optional params with [[
#4537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
✅ Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This seems a good change but I guess it is not completely resolving nuxt/nuxt#13408 considering we might have more than one optional param in the path... (Side note: Both server routes and vue-router does not have this consideration that "last dynamic segment is necessarily optional". i was unaware even we were doing this!) |
|
@pi0 How about we change the default to non-optional at end of route, and use double brackets - e.g. |
|
Double bracket seems a nice idea! |
danielroe
added
enhancement
danielroe
changed the title
[slug]/index.vue param should be optional[[
|
I love this idea! |
|
Happy to merge once the documentation is updated. Any blockers @pi0 ? |
pi0
approved these changes
Apr 26, 2022
Merged
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves nuxt/nuxt#13408. Also see nuxt/nuxt#13788.
❓ Type of change
📚 Description
Currently routes ending in a dynamic param are marked as optional, e.g.:
~/pages/[slug].vue.This PR instead requires double bracket syntax to enable optional params: e.g.
~/pages/[[slug]].vue. (This also means you can enable optional parameters earlier in the path.)👉 Migration
If you are relying on
[slug]at the end of a route to generate an optional parameter, you will need to rewrite it as[[slug]].