Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs(concepts): change phrasing #4601

Merged
merged 1 commit into from
Apr 26, 2022
Merged

docs(concepts): change phrasing #4601

merged 1 commit into from
Apr 26, 2022

Conversation

sammce
Copy link
Contributor

@sammce sammce commented Apr 25, 2022

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Changes the phrasing of a sentence on the 'Vue.js development' page in the 'concepts' section to be more grammatically correct.

The previous phrasing was grammatically incorrect.
@netlify
Copy link

netlify bot commented Apr 25, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 43602f2
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6266f1002c1cab0008feae37
😎 Deploy Preview https://deploy-preview-4601--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be "which allowed you" instead?

@sammce
Copy link
Contributor Author

sammce commented Apr 26, 2022

My rationale for using 'allows' was because Vue 3 still offers the Options API. If Vue 3 completely deprecated the Options API I would definitely use 'allowed'.

I view the explanation in the docs as an objective definition of what the Options API is, not was, hence the present tense.

I suppose either would work though.

@pi0 pi0 merged commit 45935e0 into nuxt:main Apr 26, 2022
@pi0
Copy link
Member

pi0 commented Apr 26, 2022

Thanks.

@pi0 pi0 mentioned this pull request May 2, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants