Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

docs(api): improve useFetch docs for body type and additional ohmyfetch options #4985

Merged
merged 4 commits into from
May 20, 2022
Merged

docs(api): improve useFetch docs for body type and additional ohmyfetch options #4985

merged 4 commits into from
May 20, 2022

Conversation

ArthurMJ96
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Added useFetch API documentation for Request body option.
Changed useFetch Params documentation for Options to mention which types it extends.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented May 14, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit 859b4d5
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6285403001436600089fc58e

@ArthurMJ96 ArthurMJ96 changed the title Docs api use fetch docs: add useFetch API documentation for Request body & extended types. May 14, 2022
@danielroe danielroe added the documentation Improvements or additions to documentation label May 16, 2022
atinux
atinux approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@atinux atinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing is that we shall avoid linking to source code since it can change with time.

@pi0 pi0 changed the title docs: add useFetch API documentation for Request body & extended types. docs(api): improve useFetch docs for body type and additional ohmyfetch options May 20, 2022
pi0
pi0 approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 2a43cb4 into nuxt:main May 20, 2022
@ArthurMJ96 ArthurMJ96 deleted the docs-api-useFetch branch May 20, 2022 19:58
@pi0 pi0 mentioned this pull request Jun 10, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

@atinux atinux atinux approved these changes

Assignees
No one assigned
Labels
3.x documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArthurMJ96 @atinux @pi0 @danielroe