This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(nuxt)!: support universal global middleware #5038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β Deploy Preview for nuxt3-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Looks good to me β€οΈ , would be nice to add a test for. |
As discussed with @danielroe remaining changes:
|
7 tasks
@pi0 Let me know when you plan to review this and I will resolve conflicts. |
@danielroe You can rebase. I think we are close to merge :) |
pi0
approved these changes
Jun 27, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.x
enhancement
New feature or request
π° p2-nice-to-have
Priority 2: nothing is broken but it's worth addressing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#13888, closes #4795
β Type of change
π Description
This adds support for global middleware in the universal router - ie. even if the user doesn't have a
pages/
directory. Note that only global middleware is supported so middleware must have a.global.ts
suffix for it to be applied on route navigation. (This is for consistency.)π Migration
pages:middleware:extend
hook, then you can switch to usingapp:resolve
, where you will be able to accessapp.middleware
.π Checklist