Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): support RouterView props in NuxtPage #5272

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14095

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds support to NuxtPage for features present in RouterView:

It also allows RouterView to handle attrs for consistency.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jun 3, 2022
@danielroe danielroe requested a review from pi0 June 3, 2022 09:17
@danielroe danielroe self-assigned this Jun 3, 2022
@netlify
Copy link

netlify bot commented Jun 3, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit be5f364
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6299d1b0ebd179000801f8c7

@pi0 pi0 changed the title fix(nuxt): support RouterView props in NuxtPage fix(nuxt): support RouterView props in NuxtPage Jun 3, 2022
@pi0 pi0 merged commit eb12c7a into main Jun 3, 2022
@pi0 pi0 deleted the fix/router-view-compat branch June 3, 2022 14:01
@pi0 pi0 mentioned this pull request Jun 10, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuxtPage typing doesn't allow passing custom props.
2 participants