Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

refactor(components): use inline templates #555

Merged
merged 4 commits into from
Sep 23, 2021
Merged

refactor(components): use inline templates #555

merged 4 commits into from
Sep 23, 2021

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Sep 23, 2021 •
edited
Loading

🔗 Linked issue

nuxt/nuxt#11758

❓ Type of change

  • Enhancement (improving an existing functionality like performance)

📚 Description

  • Remove lodash template components.tmpl.mjs
  • Add componentsTemplate with getContent api
  • Add a template util function createImportMagicComments

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@clarkdo clarkdo requested a review from pi0 September 23, 2021 14:24
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 23, 2021 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8b3da59
Status: ✅  Deploy successful!
Preview URL: https://a77e9508.framework-1rm.pages.dev

View logs

@pi0 pi0 changed the title refactor(app): replace runtime templates refactor(components): use inline templates Sep 23, 2021
@clarkdo clarkdo requested a review from pi0 September 23, 2021 15:53
@clarkdo clarkdo mentioned this pull request Sep 23, 2021
Merged
3 tasks
pi0
pi0 approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@pi0 pi0 merged commit c4e4688 into main Sep 23, 2021
@pi0 pi0 deleted the refactor/runtime-template branch September 23, 2021 17:57
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clarkdo @pi0 @danielroe