Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxi): load .env file before starting dev server #6119

Merged
merged 3 commits into from
Jul 25, 2022
Merged

fix(nuxi): load .env file before starting dev server #6119

merged 3 commits into from
Jul 25, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves nuxt/nuxt#14365

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

We load .env for nuxi preview and even later in the process, so it seems reasonable to read it in before starting the dev server, allowing host/port to be defined there when developing.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Jul 25, 2022
@danielroe danielroe requested a review from pi0 July 25, 2022 11:41
@netlify
Copy link

netlify bot commented Jul 25, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 3ca201f
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62de857dce67ee000840ec11

@danielroe danielroe added bug Something isn't working cli 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing labels Jul 25, 2022
@danielroe danielroe requested a review from pi0 July 25, 2022 11:59
@pi0 pi0 changed the title fix(nuxi): read .env file before starting dev server fix(nuxi): load .env file before starting dev server Jul 25, 2022
@pi0 pi0 merged commit 40defd9 into main Jul 25, 2022
@pi0 pi0 deleted the fix/dev-env branch July 25, 2022 12:01
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working cli 🍰 p2-nice-to-have Priority 2: nothing is broken but it's worth addressing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nuxi does not load .env file for NUXT_HOST and NUXT_PORT
2 participants