Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): don't call renderMeta if it is not defined #6201

Merged
merged 2 commits into from
Jul 28, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

.renderMeta is not defined in SPA mode. I think we should also serialize app.head for use in this context, but that can be a follow-up PR.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Jul 28, 2022
@danielroe danielroe requested a review from pi0 July 28, 2022 09:42
@danielroe danielroe self-assigned this Jul 28, 2022
@netlify
Copy link

netlify bot commented Jul 28, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 31bf5d4
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62e272c9ba733b000a3497b8

@jkneepkens
Copy link

This bug completely destroyed our dev and build step, as we have ssr set on false in the config. Hopefully it can be merged and deployed quickly!

@danielroe danielroe requested review from antfu and atinux July 28, 2022 12:24
@atinux atinux merged commit 748b063 into main Jul 28, 2022
@atinux atinux deleted the fix/render-meta branch July 28, 2022 13:11
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants